New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/ConfigKeyService: add 'config-key dump' to show keys and vals #14858

Merged
merged 2 commits into from May 2, 2017

Conversation

Projects
None yet
3 participants
@dmick
Member

dmick commented Apr 28, 2017

Signed-off-by: Dan Mick dan.mick@redhat.com

@dmick dmick changed the title from mon/ConfigKeyService: add 'config-key dump' to show keys and vals to DNM: mon/ConfigKeyService: add 'config-key dump' to show keys and vals Apr 28, 2017

@dmick dmick changed the title from DNM: mon/ConfigKeyService: add 'config-key dump' to show keys and vals to mon/ConfigKeyService: add 'config-key dump' to show keys and vals Apr 28, 2017

mon/ConfigKeyService: add 'config-key dump' to show keys and vals
Signed-off-by: Dan Mick <dan.mick@redhat.com>
@liewegas

This comment has been minimized.

Member

liewegas commented Apr 28, 2017

Add to qa/workunits/mon/cephtool.sh ?

@dmick

This comment has been minimized.

Member

dmick commented Apr 28, 2017

maybe you mean qa/workunits/cephtool/test.sh, but there's no config-key testing at all there currently. There's qa/workunits/mon/test_mon_config_key.py, but it wasn't even currently testing list; I could add both, certainly.

qa/workunits/mon/test_mon_config_key.py: add test for list and dump
Signed-off-by: Dan Mick <dan.mick@redhat.com>
@dmick

This comment has been minimized.

Member

dmick commented Apr 28, 2017

Added test in qa/workunits/mon/test_mon_config_key.py

@yuriw yuriw merged commit 3a68017 into ceph:master May 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dmick dmick deleted the dmick:wip-config-dump branch May 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment