New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/OSDMap: should update input param if osd dne #14863

Merged
merged 4 commits into from Apr 28, 2017

Conversation

Projects
None yet
4 participants
@tchaikov
Contributor

tchaikov commented Apr 28, 2017

No description provided.

tchaikov added some commits Apr 28, 2017

test/test_async_driver: silence clang static analyzer warning
Signed-off-by: Kefu Chai <kchai@redhat.com>
common/obj_bencher: silence divide by zero warning
Signed-off-by: Kefu Chai <kchai@redhat.com>
osd/OSDMap: should update input param if osd dne
Signed-off-by: Kefu Chai <kchai@redhat.com>
@badone

badone approved these changes Apr 28, 2017

LGTM

common/hobject: use string::append() to avoid temp object
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov added the needs-qa label Apr 28, 2017

@@ -1663,7 +1663,7 @@ void OSDMap::_remove_nonexistent_osds(const pg_pool_t& pool,
if (removed)
osds.resize(osds.size() - removed);
} else {
for (auto osd : osds) {
for (auto& osd : osds) {

This comment has been minimized.

@liewegas

liewegas Apr 28, 2017

Member

good catch!!

@liewegas

liewegas Apr 28, 2017

Member

good catch!!

@liewegas liewegas merged commit eaacbdf into ceph:master Apr 28, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-kill-clang-warnings branch Apr 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment