New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/erasure-code: override min_size to 2 #14872

Merged
merged 2 commits into from Apr 29, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Apr 28, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Apr 28, 2017

Hmm, your diagnosis in the bug has me worried. Shouldn't this be backfilling even though it is below min_size?

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 28, 2017

  // We go incomplete if below min_size for ec_pools since backfill
  // does not currently maintain rollbackability
  // Otherwise, we will go "peered", but not "active"
  if (num_want_acting < pool.info.min_size &&
      (pool.info.ec_pool() ||
       !cct->_conf->osd_allow_recovery_below_min_size)) {
    want_acting.clear();
    dout(10) << "choose_acting failed, below min size" << dendl;
    return false;
  }

quote from PG::choose_acting().

does this answer your q?

@liewegas

This comment has been minimized.

Member

liewegas commented Apr 28, 2017

tchaikov added some commits Apr 28, 2017

qa/tasks/rados: add optional setting of "min_size"
this setting only affects the newly created pool

Fixes: http://tracker.ceph.com/issues/19770
Signed-off-by: Kefu Chai <kchai@redhat.com>
qa/erasure-code: override min_size to 2
so isa(k=2,m=1) can survive with 1 down OSD.

Fixes: http://tracker.ceph.com/issues/19770
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 29, 2017

@yuriw sorry the tests involving "qa/erasure-code/ec-rados-plugin=isa-k=2-m=1.yaml" would fail, see http://pulpito.ceph.com/kchai-2017-04-28_14:27:25-rados-wip-14820-kefu---basic-mira/.

rerunning the test at http://pulpito.ceph.com/kchai-2017-04-29_02:44:22-rados-wip-14820-kefu---basic-smithi/

@tchaikov tchaikov merged commit 6b34e18 into ceph:master Apr 29, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-19770 branch Apr 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment