New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: info command should indicate if parent is in trash #14875

Merged
merged 4 commits into from May 3, 2017

Conversation

Projects
None yet
2 participants
@dillaman
Contributor

dillaman commented Apr 28, 2017

No description provided.

@trociny

This comment has been minimized.

Contributor

trociny commented Apr 30, 2017

@dillaman Don't you want to add rbd_get_parent_info2 and rbd_trash_get to python API in this PR?

@dillaman

This comment has been minimized.

Contributor

dillaman commented May 1, 2017

@trociny I had added trash_get to the Python API [1] but I hesitated to add a "parent_info2" method to the Python API since I didn't want to break the API nor add a xyz2 method. Perhaps I'll just add a new parent_id method.

[1] b1e7df2#diff-fce2cce0427655819a41045797549a2cR925

dillaman added some commits Apr 28, 2017

librbd: get_parent_info should return cached parent name
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: extended parent info API to retrieve parent id
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: added trash_get API method to retrieve image status
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd: info command should indicate if parent is in trash
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@trociny

This comment has been minimized.

Contributor

trociny commented May 1, 2017

Ah, sorry, I missed python's trash_get somehow.

I like the idea with parent_id python method. Actually, I even think that doing the same for C API (rbd_get_parent_id instead of rbd_get_parent_info2) could be a good idea too. It would be similar to rbd_get_id we have.

But I am fine with rbd_get_parent_info2 too.

@trociny trociny self-assigned this May 3, 2017

@trociny

trociny approved these changes May 3, 2017

lgtm

@trociny trociny merged commit 1698b8f into ceph:master May 3, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dillaman dillaman deleted the dillaman:wip-rbd-trash-parent branch May 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment