New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cls/log/cls_log.cc: reduce logging noise #14879

Merged
merged 1 commit into from May 3, 2017

Conversation

Projects
None yet
3 participants
@wjwithagen
Contributor

wjwithagen commented Apr 29, 2017

  • The other reference in the source as already at 20.
    ./src/cls/timeindex/cls_timeindex.cc:85:
    CLS_LOG(20, "storing entry at %s", index.c_str());

    And we need not always know where in the log items are stored.
    So it looks like a leftover debug feature.

Fixes: http://tracker.ceph.com/issues/19835
Signed-off-by: Willem Jan Withagen wjw@digiware.nl

@wjwithagen wjwithagen requested a review from yehudasa Apr 29, 2017

@wjwithagen wjwithagen added the cleanup label Apr 29, 2017

@cbodley

cbodley approved these changes May 1, 2017

@jharbott

This comment has been minimized.

Contributor

jharbott commented May 3, 2017

Thanks for this patch, please also mark for backporting.

@cbodley

This comment has been minimized.

Contributor

cbodley commented May 3, 2017

@wjwithagen created a backport ticket at http://tracker.ceph.com/issues/19835, could you please add to your commit message?

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented May 3, 2017

@cbodley
Yup, added commit message, but the wrong way around, I guess. Added it to the tracker.
But will also add tracker-id to the actual commit.

cls/log/cls_log.cc: reduce logging noise
 - The other reference in the source as already at 20.
      ./src/cls/timeindex/cls_timeindex.cc:85:
	CLS_LOG(20, "storing entry at %s", index.c_str());

   And we need not always know where in the log items are stored.
   So it looks like a leftover debug feature.

Fixes: http://tracker.ceph.com/issues/19835
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

@cbodley cbodley merged commit c124b05 into ceph:master May 3, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment