Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
rgw: continuation of the auth rework -- AWSv4 #14885
This PR is the third part of the authentication & authorisation rework. It's focused on extending support for the AWSv4 schema across S3 auth engines.
Many low-level primitives have been dissected as-is from the current code and just encapsulated behind new interfaces. Potential clean-ups (like switching from
The branch has been verified with s3-tests (both in AWSv2 and AWSv4), Tempest and AWS Java SDK (the AWSv4's streaming mode: UploadObjectSingleOperation.java).
The Teuthology run (http://pulpito.ceph.com/rzarzynski-2017-04-30_16:48:24-rgw-wip-rgw-auth-rework-cont-3-awsv4---basic-mira/) hasn't found a regression. The failures were caused by:
I think this changeset is ready to merge, and in particular, that @tchaikov's point was addressed. In addition to posted Teuthology runs, I've run this code and seen no regression (I'm looking at a problem with a Java-initiated streaming upload in my test setup, but it reproduces identically with current master as with this change).