Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: Implement asynchronous scrub sleep #14886

Merged
merged 1 commit into from May 9, 2017

Conversation

Projects
None yet
5 participants
@badone
Copy link
Contributor

badone commented Apr 30, 2017

Rather than blocking the main op queue just do an async sleep.

Fixes: http://tracker.ceph.com/issues/19497

Signed-off-by: Brad Hubbard bhubbard@redhat.com

@badone

This comment has been minimized.

@badone badone added needs-review and removed needs-qa labels Apr 30, 2017

<< ceph_clock_now() - scrubber.sleep_start
<< ", re-queuing scrub" << dendl;
scrub_queued = false;
lock();

This comment has been minimized.

Copy link
@jdurgin

jdurgin May 2, 2017

Member

looks like the pg lock should be held for the whole duration of the callback, to protect the scrubber object modifications

This comment has been minimized.

Copy link
@jdurgin

jdurgin May 2, 2017

Member

otherwise looks good!

This comment has been minimized.

Copy link
@badone

badone May 2, 2017

Author Contributor

@jdurgin changed

@badone badone force-pushed the badone:wip-async-osd-scrub-sleep branch from 410d815 to 6e28ec7 May 2, 2017

@jdurgin

jdurgin approved these changes May 3, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented May 4, 2017

@badone needs rebase

osd: Implement asynchronous scrub sleep
Rather than blocking the main op queue just do an async sleep.

Fixes: http://tracker.ceph.com/issues/19497

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

@badone badone force-pushed the badone:wip-async-osd-scrub-sleep branch from 6e28ec7 to 7af3e86 May 5, 2017

@tchaikov tchaikov merged commit 1116556 into ceph:master May 9, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@badone badone deleted the badone:wip-async-osd-scrub-sleep branch May 9, 2017

@markhpc

This comment has been minimized.

Copy link
Member

markhpc commented May 19, 2017

This appears to be adding a new timer thread for every single PG. While I haven't traced it specifically to this commit, I'm currently seeing something like 4000 safe_timer threads via a wallclock profile on my test setup and this is the most likely culprit so far.

@610744039

This comment has been minimized.

Copy link

610744039 commented Jun 1, 2017

How do I test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.