Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/OSDMonitor: update creating_pgs using pending_creatings #14897

Merged
merged 1 commit into from May 2, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Copy link
Contributor

tchaikov commented May 1, 2017

  • without this change, in OSDMonitor::update_pending_pgs(), creating_pgs
    is updated directly without lock, and the change will be overwritten
    with pending changes eventually. so we should update it using
    pending_creatings
  • also, should acquire the lock in OSDMonitor::send_pg_creates() when
    reading creating_pgs_by_osd_epoch and createing_pgs.

Fixes: http://tracker.ceph.com/issues/19814
Signed-off-by: Kefu Chai kchai@redhat.com

mon/OSDMonitor: update creating_pgs using pending_creatings
* without this change, in OSDMonitor::update_pending_pgs(), creating_pgs
  is updated directly without lock, and the change will be overwritten
  with pending changes eventually. so we should update it using
  pending_creatings
* also, should acquire the lock in OSDMonitor::send_pg_creates() when
  reading creating_pgs_by_osd_epoch and createing_pgs.

Fixes: http://tracker.ceph.com/issues/19814
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented May 1, 2017

we could avoid resending the pg-create message for already-created pgs if we could tell if the creating_pg in pgmap is stale or not. but we cannot. because pgmap.last_pg_scan is global: any pgstat will update the epoch.

the upside of this problem is that, it does not hurt. and this issue will go away, once osd stops sending pgstats.

@liewegas liewegas merged commit f36f0db into ceph:master May 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-19814 branch May 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.