New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: stop mgrc earlier in shutdown() #14904

Merged
merged 1 commit into from May 2, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented May 2, 2017

it's better this way, as MgrClient is more like an internal consumer
of the services offered by OSD, instead of service privider. it could
prevent future problem if we can stop it earlier in the shutdown
process.

see also: http://tracker.ceph.com/issues/19638
Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov requested review from liewegas and jdurgin May 2, 2017

@liewegas liewegas changed the title from OSD: stop mgrc earlier in shutdown() to osd: stop mgrc earlier in shutdown() May 2, 2017

OSD: stop mgrc earlier in shutdown()
it's better this way, as MgrClient is more like an internal consumer
of the services offered by OSD, instead of service privider. it could
prevent future problem if we can stop it earlier in the shutdown
process.

see also: http://tracker.ceph.com/issues/19638
Signed-off-by: Kefu Chai <kchai@redhat.com>
@liewegas

This comment has been minimized.

Member

liewegas commented May 2, 2017

yeah looks good!

@liewegas liewegas merged commit 7f97f36 into ceph:master May 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-19638-followon branch May 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment