New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logclient: use the seq id of the 1st log entry when resetting session #14927

Merged
merged 1 commit into from May 5, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented May 3, 2017

logclient: use the seq id of the 1st log entry when resetting session

because do_log() does not update last_log (see LogClient::get_next_seq())
and log_queue atomically, and log_queue is updated after last_log, so
we can not use them to figure out the number of log entries to be sent.
so, we choose to trust log_queue in this change.

Fixes: http://tracker.ceph.com/issues/19427
Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov requested review from liewegas and jecluis May 3, 2017

logclient: use the seq id of the 1st log entry when resetting session
because do_log() does not update last_log (see LogClient::get_next_seq())
and log_queue atomically, and log_queue is updated *after* last_log, so
we can not use them to figure out the number of log entries to be sent.
so, we choose to trust log_queue in this change.

Fixes: http://tracker.ceph.com/issues/19427
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov changed the title from logclient: do not assert on queue size and last_log to logclient: use the seq id of the 1st log entry when resetting session May 3, 2017

@tchaikov tchaikov requested a review from jdurgin May 3, 2017

@jdurgin

jdurgin approved these changes May 3, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 5, 2017

@tchaikov tchaikov merged commit 6e1e540 into ceph:master May 5, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-19427 branch May 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment