Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: optimize DaemonStateIndex::cull() a little bit #14967

Merged
merged 1 commit into from May 17, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Copy link
Contributor

tchaikov commented May 5, 2017

if the size of the cluster is quite large, we don't need to walk through
all daemons to do the cull.

  • smaller scope protected by the lock
  • check smaller range in "all"
  • use vector for holding victims: all of them are of
    "daemon_type".

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov requested a review from jcsp May 5, 2017

mgr: optimize DaemonStateIndex::cull() a little bit
if the size of the cluster is quite large, we don't need to walk through
all daemons to do the cull.

* smaller scope protected by the lock
* check smaller range in "all"
* use vector<string> for holding victims: all of them are of
  "daemon_type".

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov force-pushed the tchaikov:wip-faster-cull branch from 26a1ebf to 0e7137a May 5, 2017

@jcsp

jcsp approved these changes May 11, 2017

@liewegas liewegas merged commit 16cce5a into ceph:master May 17, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-faster-cull branch May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.