Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
osd: sched_scrub() lock pg only if all scrubbing conditions are fulfilled #14968
changed the title from
osd/OSD.cc: OSD::sched_scrub() should only locks this pg when all scrubbing conditional checks have passed
osd: sched_scrub() should not lock pg unless all scrubbing conditions are fulfilled
May 5, 2017
May 8, 2017
@liewegas I have one question about scrub:
@liupan1111 we'd better bring this kind of discussion to the mailing list instead of asking it right on the github's PR page, it would be more visible to other developer. and since the mails will be archived, they will benefit other developers in a better way.
i think, we use
This random backoff was part of the original scrub scheduling from forever ago; I don't remember very well, but I think the problem was that all OSDs would try to do a scrub reservation at once and fail? I don't think it is still a problem. I suggest removing it and watching scrub behavior carefully to make sure it behaves well.
@tchaikov thanks, I will remember to send to mail list next time.
The safetimer will be trigered in future 1 second after sched_scrub();