New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crush: update documentation for negative choose step #14970

Merged
1 commit merged into from May 6, 2017

Conversation

Projects
None yet
3 participants
@ghost

ghost commented May 5, 2017

Signed-off-by: Loic Dachary loic@dachary.org

@ghost ghost added the documentation label May 5, 2017

@ghost ghost requested a review from smithfarm May 5, 2017

* to select is determined by the __max_result__ argument of
* crush_do_rule(), i.e. __arg1__ is __max_result__ minus the number of
* items already in the result.
* In all __CHOOSE__ steps, if __arg1__ is lower or equal to zero, the

This comment has been minimized.

@smithfarm

smithfarm May 5, 2017

Contributor

s/lower or equal to/less than or equal to/

* items already in the result.
* In all __CHOOSE__ steps, if __arg1__ is lower or equal to zero, the
* number of items to select is the __max_result__ argument of
* crush_do_rule() minus __arg1__. It is common to set __arg1__ to

This comment has been minimized.

@smithfarm

smithfarm May 5, 2017

Contributor

Either:

"The number of items to select is determined by subtracting __arch1__ from the __max_result__ argument of crush_do_rule()."

or

"The number of items to select is equal to the __max_result__ argument of crush_do_rule() minus __arg1__."

or, possibly even better:

"The number of items to select is equal to __max_result__ minus __arg1__, where __max_result__ and __arg1__ are both arguments to crush_do_rule()."

This comment has been minimized.

@smithfarm

smithfarm May 5, 2017

Contributor

@dachary Maybe the third version (just added) is best.

This comment has been minimized.

@ghost

ghost May 5, 2017

The third version is incorrect: only max_result is an argument of do_rule. The arg1 is an argument of the rulestep. I like the second version actually, much clearer !

crush: update documentation for negative choose step
And remove an obsolete comment.

Signed-off-by: Loic Dachary <loic@dachary.org>
@ghost

This comment has been minimized.

ghost commented May 5, 2017

@smithfarm updated and repushed !

@ghost ghost merged commit 6152fd9 into ceph:master May 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment