New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rbd: rbd-mirror: failover and failback of unmodified image results in split-brain #14977

Merged
merged 2 commits into from Aug 27, 2017

Conversation

Projects
None yet
3 participants
@dillaman
Contributor

dillaman commented May 5, 2017

dillaman added some commits May 4, 2017

rbd-mirror: prevent infinite loop when computing replay status
If the image had a non-primary predecessor epoch whose tag tid
duplicates an epoch within its own journal, an infinite loop
would result.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 3f179bf)
librbd: add no-op event when promoting an image
The rbd-mirror process needs an event in the journal
to properly detect the transition between primary and
non-primary state between peers.

Fixes: http://tracker.ceph.com/issues/19858
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 4031555)

Conflicts:
	src/librbd/journal/DemoteRequest.cc: logic exists in Journal.cc

(cherry picked from commit 7970ec5)

Conflicts:
	src/librbd/journal/PromoteRequest.[h|cc]: logic exists in Journal.cc
	src/librbd/journal/Types.[h|cc]: trivial resolution
	src/test/librbd/journal/test_mock_PromoteRequest.cc: does not exist

@dillaman dillaman added this to the jewel milestone May 5, 2017

@trociny

trociny approved these changes May 5, 2017

lgtm

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jun 19, 2017

Contributor

Jenkins re-test this please

Contributor

smithfarm commented Jun 19, 2017

Jenkins re-test this please

@smithfarm smithfarm changed the title from jewel: rbd-mirror: failover and failback of unmodified image results in split-brain to jewel: rbd: rbd-mirror: failover and failback of unmodified image results in split-brain Jul 12, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 22, 2017

Contributor

The following three rbd-related PRs were included in a recent jewel integration branch:

An rbd suite was run on said branch, and it failed rather spectacularly: http://pulpito.front.sepia.ceph.com/smithfarm-2017-08-21_20:07:45-rbd-wip-jewel-backports-distro-basic-smithi/

@dillaman Could you rebase/repush wip-19873-jewel to ceph-ci? I'll run an rbd suite on this single PR. Or do you have another suggestion?

Contributor

smithfarm commented Aug 22, 2017

The following three rbd-related PRs were included in a recent jewel integration branch:

An rbd suite was run on said branch, and it failed rather spectacularly: http://pulpito.front.sepia.ceph.com/smithfarm-2017-08-21_20:07:45-rbd-wip-jewel-backports-distro-basic-smithi/

@dillaman Could you rebase/repush wip-19873-jewel to ceph-ci? I'll run an rbd suite on this single PR. Or do you have another suggestion?

@dillaman

This comment has been minimized.

Show comment
Hide comment
@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 25, 2017

Contributor

@dillaman Thanks. Now that luminous testing got underway again, I'm no longer doing runs for individual PRs. This PR was included in this run, which is exhibiting a new failure: http://pulpito.ceph.com/smithfarm-2017-08-24_15:58:59-rbd-wip-jewel-backports-distro-basic-smithi/

Contributor

smithfarm commented Aug 25, 2017

@dillaman Thanks. Now that luminous testing got underway again, I'm no longer doing runs for individual PRs. This PR was included in this run, which is exhibiting a new failure: http://pulpito.ceph.com/smithfarm-2017-08-24_15:58:59-rbd-wip-jewel-backports-distro-basic-smithi/

@trociny

This comment has been minimized.

Show comment
Hide comment
@trociny

trociny Aug 25, 2017

Contributor

The teuthology failures do not look related.

Contributor

trociny commented Aug 25, 2017

The teuthology failures do not look related.

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 26, 2017

Contributor

@dillaman This passed an rbd suite at http://tracker.ceph.com/issues/20613#note-22 and a rados suite at http://tracker.ceph.com/issues/20613#note-20

Please review.

Contributor

smithfarm commented Aug 26, 2017

@dillaman This passed an rbd suite at http://tracker.ceph.com/issues/20613#note-22 and a rados suite at http://tracker.ceph.com/issues/20613#note-20

Please review.

@dillaman

lgtm (can't approve my own PR)

@smithfarm smithfarm merged commit de27247 into ceph:jewel Aug 27, 2017

6 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment