New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: client_quota no longer optional #14978

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
4 participants
@dvanders
Contributor

dvanders commented May 5, 2017

Remove the possibility to disable client quotas.

Signed-off-by: Dan van der Ster daniel.vanderster@cern.ch

client: client_quota no longer optional
Remove the possibility to disable client quotas.

Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
@liewegas

This comment has been minimized.

Member

liewegas commented May 5, 2017

This seems reasonable to me! @jcsp?

@ktdreyer

This comment has been minimized.

Member

ktdreyer commented May 5, 2017

deleting lines from src/common/config_opts.h? 😍

@ktdreyer ktdreyer requested a review from jcsp May 5, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented May 5, 2017

I know! 🍻

@jcsp

jcsp approved these changes May 10, 2017

I'm on board. While it's sort of useful to be able to turn off functionality to work around unknown-unknown issues, in this case that's overridden by how it makes admin/support harder if clients can too easily disobey quotas.

@jcsp jcsp merged commit 0f250a8 into ceph:master May 15, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment