New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/async/net_handler: errno should be stored before calling next function #14985

Merged
merged 1 commit into from May 9, 2017

Conversation

Projects
None yet
3 participants
@johnzzpcrystal
Contributor

johnzzpcrystal commented May 5, 2017

Signed-off-by: Zhou Zhengping johnzzpcrystal@gmail.com

@tchaikov

lgtm modulo the nit

return -errno;
r = -errno;
lderr(cct) << __func__ << " fcntl(F_GETFL) failed: " << cpp_strerror(r) << dendl;
return r;

This comment has been minimized.

@tchaikov

tchaikov May 6, 2017

Contributor

nit, could be more consistent: assign errrno to r (w/o negation), and then return -r (w/ negation)

This comment has been minimized.

@johnzzpcrystal

johnzzpcrystal May 6, 2017

Contributor

Yes, I agree with you, I'll do it

@tchaikov tchaikov added the cleanup label May 6, 2017

msg/async/net_handler: errno should be stored before next calling
Signed-off-by: Zhou Zhengping <johnzzpcrystal@gmail.com>

@tchaikov tchaikov merged commit 73340ee into ceph:master May 9, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@johnzzpcrystal johnzzpcrystal deleted the johnzzpcrystal:store_errno branch May 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment