New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw_rados: create sync module instances only if run_sync_thread is set #14994

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
3 participants
@theanalyst
Member

theanalyst commented May 8, 2017

This allows for radosgw-admin to run even if there was a
misconfiguration in setting tier types which would otherwise make it
difficult to revert an invalid tier type setting. Since sync modules are
necessary only for rgw and not for the admin itself, this allows for
invalid tier configurations to be corrected as rgw-admin wouldn't fail

Fixes: http://tracker.ceph.com/issues/19830

@theanalyst theanalyst requested review from yehudasa and cbodley May 8, 2017

@cbodley

This comment has been minimized.

@cbodley

This comment has been minimized.

Contributor

cbodley commented May 19, 2017

@theanalyst there's an extra 'Signed-off-by: Casey Bodley <cbodley@suse.com>' in the commit message

rgw_rados: create sync module instances only if run_sync_thread is set
This allows for radosgw-admin to run even if there was a
misconfiguration in setting tier types which would otherwise make it
difficult to revert an invalid tier type setting. Since sync modules are
necessary only for rgw and not for the admin itself, this allows for
invalid tier configurations to be corrected as rgw-admin wouldn't fail

Fixes: http://tracker.ceph.com/issues/19830
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
@theanalyst

This comment has been minimized.

Member

theanalyst commented May 19, 2017

@cbodley sorry wierd C-c C-v error, fixed

@cbodley

This comment has been minimized.

Contributor

cbodley commented May 19, 2017

thanks, good to merge once the build check completes

@cbodley cbodley merged commit e01fd68 into ceph:master May 19, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment