New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: rpm: fix python-Sphinx package name for SUSE #15015

Merged
merged 1 commit into from May 9, 2017

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented May 9, 2017

This commit moves "BuildRequires: python-sphinx" down to the RH/CentOS/Fedora
distro conditional and adds a "BuildRequires: python-Sphinx" to the SUSE
conditional.

Signed-off-by: Jan Matejek jmatejek@suse.com
Signed-off-by: Nathan Cutler ncutler@suse.com

build/ops: rpm: fix python-Sphinx package name for SUSE
This commit moves "BuildRequires: python-sphinx" down to the RH/CentOS/Fedora
distro conditional and adds a "BuildRequires: python-Sphinx" to the SUSE
conditional.

Signed-off-by: Jan Matejek <jmatejek@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm added the build/ops label May 9, 2017

@smithfarm smithfarm requested review from tchaikov and ktdreyer May 9, 2017

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented May 9, 2017

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented May 9, 2017

@matejcik Does this look good to you?

@matejcik

This comment has been minimized.

matejcik commented May 9, 2017

@smithfarm this looks ok from my (SUSE) side... not surprising, given that i'm the author of the change :)
Someone from the Fedora/RHEL side should check this though.

@ktdreyer

LGTM, thanks.

@smithfarm smithfarm merged commit 46d52c5 into ceph:master May 9, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@smithfarm smithfarm deleted the smithfarm:wip-sphinx branch May 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment