Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-disk: separate ceph-osd --check-needs-* logs #15016

Merged
1 commit merged into from May 10, 2017

Conversation

Projects
None yet
2 participants
@ghost
Copy link

ghost commented May 9, 2017

It is using the OSD id zero but have nothing to do with OSD zero and
this is confusing to the user. The log themselves do not need to be kept
around and are stored in the run directory so that they can be disposed
of after reboot.

Fixes: http://tracker.ceph.com/issues/19888

Signed-off-by: Loic Dachary loic@dachary.org

@ghost ghost added cleanup core labels May 9, 2017

@ghost ghost requested a review from ktdreyer May 9, 2017

ceph-disk: separate ceph-osd --check-needs-* logs
It is using the OSD id zero but have nothing to do with OSD zero and
this is confusing to the user. The log themselves do not need to be kept
around and are stored in the run directory so that they can be disposed
of after reboot.

Fixes: http://tracker.ceph.com/issues/19888

Signed-off-by: Loic Dachary <loic@dachary.org>
@ktdreyer
Copy link
Member

ktdreyer left a comment

Looks sane to me (untested)

@ghost

This comment has been minimized.

Copy link
Author

ghost commented May 9, 2017

pushed to ceph-ci

@ghost

This comment has been minimized.

Copy link
Author

ghost commented May 9, 2017

teuthology-suite -k distro --verbose --suite ceph-disk --ceph wip-19888-ceph-disk  --machine-type vps

@ghost ghost merged commit acccedd into ceph:master May 10, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.