New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/bit_vector: utilize deep-copy during data decode #15017

Merged
merged 1 commit into from May 11, 2017

Conversation

Projects
None yet
2 participants
@dillaman
Contributor

dillaman commented May 9, 2017

BlueStore utilizes an in-memory cache of bufferlists. If the bit vector
directly manipulates the shallow-copied bufferlist, it can corrupt
the CRC.

Fixes: http://tracker.ceph.com/issues/19863
Signed-off-by: Jason Dillaman dillaman@redhat.com

common/bit_vector: utilize deep-copy during data decode
BlueStore utilizes an in-memory cache of bufferlists. If the bit vector
directly manipulates the shallow-copied bufferlist, it can corrupt
the CRC.

Fixes: http://tracker.ceph.com/issues/19863
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@liewegas

This comment has been minimized.

Member

liewegas commented May 10, 2017

passes regular rados suite http://pulpito.ceph.com/sage-2017-05-10_03:08:19-rados-wip-sage-testing2---basic-smithi/

should go through teh qemu tests tho!

@dillaman

This comment has been minimized.

@liewegas liewegas merged commit 381f465 into ceph:master May 11, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@liewegas

This comment has been minimized.

Member

liewegas commented May 11, 2017

yay! the one failure is unlreated (out of order osd op, opened http://tracker.ceph.com/issues/19911)

@dillaman dillaman deleted the dillaman:wip-19863 branch May 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment