New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind: fix open flags calculation #15018

Merged
merged 2 commits into from May 16, 2017

Conversation

Projects
None yet
3 participants
@ukernel
Member

ukernel commented May 10, 2017

(O_WRONLY | O_RDWR) is not vaiid open flags

Fixes: http://tracker.ceph.com/issues/19890
Signed-off-by: "Yan, Zheng" zyan@redhat.com

@ukernel ukernel added the cephfs label May 10, 2017

@batrick

This comment has been minimized.

Member

batrick commented May 10, 2017

@ukernel I'll add this to my integration branch.

@ukernel ukernel added the bug fix label May 10, 2017

pybind: fix open flags calculation
(O_WRONLY | O_RDWR) is invaild open flags

Fixes: http://tracker.ceph.com/issues/19890
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
@jcsp

This comment has been minimized.

Contributor

jcsp commented May 11, 2017

Do we know which code change caused this failure? It seems like we're working around it at the python layer, perhaps we should be fixing the underlying code to tolerate (O_WRONLY | O_RDWR) the way I guess it used to?

@ukernel

This comment has been minimized.

Member

ukernel commented May 12, 2017

commit "fs: normalize file open flags internally used by cephfs" reveals this bug. linux kernel does not tolerate (O_WRONLY | O_RDWR), I don't think we should do

pybind: fix cephfs.OSError initialization
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "cephfs.pyx", line 672, in cephfs.LibCephFS.open (/home/zhyan/Ceph/ceph-2/build/src/pybind/cephfs/pyrex/cephfs.c:10160)
  File "cephfs.pyx", line 155, in cephfs.OSError.__init__ (/home/zhyan/Ceph/ceph-2/build/src/pybind/cephfs/pyrex/cephfs.c:1889)
TypeError: __init__() takes exactly 3 positional arguments (2 given)

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
@ukernel

This comment has been minimized.

Member

ukernel commented May 12, 2017

@ukernel

This comment has been minimized.

@jcsp jcsp merged commit 5efad43 into ceph:master May 16, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@ukernel ukernel deleted the ukernel:wip-19890 branch May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment