New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/PrimayLogPG: update modified range to include the whole object size for write_full op #15021

Merged
merged 2 commits into from May 15, 2017

Conversation

Projects
None yet
4 participants
@runsisi
Contributor

runsisi commented May 10, 2017

otherwise the newest clone_overlap calculated by make_writeable should not be correct

Signed-off-by: runsisi runsisi@zte.com.cn

@runsisi

This comment has been minimized.

Contributor

runsisi commented May 10, 2017

retest this please

1 similar comment
@runsisi

This comment has been minimized.

Contributor

runsisi commented May 10, 2017

retest this please

@gregsfortytwo gregsfortytwo added the core label May 10, 2017

@@ -6756,7 +6756,10 @@ void PrimaryLogPG::write_update_size_and_usage(object_stat_sum_t& delta_stats, o
uint64_t length, bool count_bytes, bool force_changesize)
{
interval_set<uint64_t> ch;
if (length)
if (force_changesize) { // write_full with object size to be changed

This comment has been minimized.

@liewegas

liewegas May 10, 2017

Member

the force_write caller doesn't always set this:

	write_update_size_and_usage(ctx->delta_stats, oi, ctx->modified_ranges,
	    0, op.extent.length, true, op.extent.length != oi.size ? true : false);

and the name doesn't make much sense.

I think

  1. we can drop count_bytes arg sinc eit is always true?
  2. write_full can unconditionally pass true for force_changesize
  3. we can rename force_changesize to bool writefull

Does that sound right?

This comment has been minimized.

@runsisi

runsisi May 11, 2017

Contributor

@liewegas updated as you suggested, please take a look, thanks!

@liewegas liewegas removed the needs-qa label May 10, 2017

runsisi added some commits May 11, 2017

runsisi
osd/PrimaryLogPG: drop parameter count_bytes for write_update_size_an…
…d_usage

Signed-off-by: runsisi <runsisi@zte.com.cn>
runsisi
osd/PrimayLogPG: update modified range to include the whole object si…
…ze for write_full op

Signed-off-by: runsisi <runsisi@zte.com.cn>

@liewegas liewegas added the needs-qa label May 11, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented May 11, 2017

@liewegas liewegas merged commit a869c9a into ceph:master May 15, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@runsisi runsisi deleted the runsisi:wip-fix-writefull branch May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment