New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore/KernelDevice: fix sync write vs flush #15034

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
4 participants
@liewegas
Member

liewegas commented May 10, 2017

No description provided.

@markhpc

This comment has been minimized.

Show comment
Hide comment
@markhpc

markhpc May 11, 2017

Member

Before merging this, I want to retest. It turns out I had forgotten to explicitly disable rbd cache in the ceph.conf file I was using, potentially resulting in a client side bottleneck for small random writes on NVMe.

Member

markhpc commented May 11, 2017

Before merging this, I want to retest. It turns out I had forgotten to explicitly disable rbd cache in the ceph.conf file I was using, potentially resulting in a client side bottleneck for small random writes on NVMe.

@liewegas liewegas requested a review from markhpc May 12, 2017

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas May 15, 2017

Member

should retest with the latest patch too.

Member

liewegas commented May 15, 2017

should retest with the latest patch too.

@markhpc

After Sage's fix, I believe performance is roughly the same with bluefs_sync_writes enabled and disabled.

@markhpc

This comment has been minimized.

Show comment
Hide comment
@markhpc

markhpc May 17, 2017

Member

Test results attached
fixed_tests.xlsx

Member

markhpc commented May 17, 2017

Test results attached
fixed_tests.xlsx

@varadakari

LGTM

os/bluestore/KernelDevice: fix flush() vs sync write()
We need to set the atomic flag so that a flush will actually flush.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas changed the title from os/bluestore/BlueFS: bluefs_sync_write=true to os/bluestore/KernelDevice: fix sync write vs flush May 19, 2017

@liewegas liewegas merged commit 069ca1a into ceph:master May 19, 2017

2 of 3 checks passed

default Build started sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@liewegas liewegas deleted the liewegas:wip-bluestore-sync-write branch May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment