New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: optimize copy-up to add hints only once to object op #15037

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
2 participants
@trociny
Contributor

trociny commented May 10, 2017

Fixes: http://tracker.ceph.com/issues/19875
Signed-off-by: Mykola Golub mgolub@mirantis.com

@@ -628,7 +629,8 @@ void ObjectTruncateRequest::send_write() {
}
}
void ObjectWriteSameRequest::add_write_ops(librados::ObjectWriteOperation *wr) {
void ObjectWriteSameRequest::add_write_ops(librados::ObjectWriteOperation *wr,
bool set_hints) {
RWLock::RLocker snap_locker(m_ictx->snap_lock);
if (m_ictx->enable_alloc_hint &&

This comment has been minimized.

@dillaman

dillaman May 15, 2017

Contributor

Why not include the guard here as well?

Mykola Golub
librbd: optimize copy-up to add hints only once to object op
Fixes: http://tracker.ceph.com/issues/19875
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
@trociny

This comment has been minimized.

Contributor

trociny commented May 15, 2017

@dillaman updated

@dillaman

lgtm

@dillaman dillaman merged commit 9b72f74 into ceph:master May 18, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@trociny trociny deleted the trociny:wip-19875 branch May 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment