New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/fio_ceph_objectstore: fix fio plugin build failure by engine_data #15044

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
3 participants
@lixiaoy1
Contributor

lixiaoy1 commented May 11, 2017

The commit in fio axboe/fio@710bf9c
changed engine_data to a union which leads build of fio_ceph_objectstore failed.

Signed-off-by: Lisa Li xiaoyan.li@intel.com

@@ -209,7 +209,7 @@ Job::Job(Engine* engine, const thread_data* td)
for (uint32_t i = 0; i < td->o.nr_files; i++) {
auto f = td->files[i];
f->real_file_size = file_size;
f->engine_data = i;

This comment has been minimized.

@tchaikov

tchaikov May 11, 2017

Contributor

it's practically identical to #15041 but is semantically different. engine_pos is for offset but not for private data storage. @majianpeng @cbodley what do you guys think?

This comment has been minimized.

@cbodley

cbodley May 11, 2017

Contributor

thank you both for looking at this. i agree that engine_pos is what we want here, as it matches what they did with other engines in axboe/fio@710bf9c:

-#define LAST_POS(f)	((f)->engine_data)
+#define LAST_POS(f)	((f)->engine_pos)

@tchaikov tchaikov added the tests label May 11, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 11, 2017

see also #15041

test/fio_ceph_objectstore: fix fio plugin build failure by engine_data
The commit in fio axboe/fio@710bf9c
changed engine_data to a union which leads build of fio_ceph_objectstore failed.

Signed-off-by: Lisa Li xiaoyan.li@intel.com
@@ -209,7 +209,7 @@ Job::Job(Engine* engine, const thread_data* td)
for (uint32_t i = 0; i < td->o.nr_files; i++) {
auto f = td->files[i];
f->real_file_size = file_size;
f->engine_data = i;

This comment has been minimized.

@cbodley

cbodley May 11, 2017

Contributor

thank you both for looking at this. i agree that engine_pos is what we want here, as it matches what they did with other engines in axboe/fio@710bf9c:

-#define LAST_POS(f)	((f)->engine_data)
+#define LAST_POS(f)	((f)->engine_pos)
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 15, 2017

tested by compiling the fio plugin following the instructions in src/test/fio/README.md.

@tchaikov tchaikov merged commit 43a5582 into ceph:master May 15, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment