New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd-mirror: resolve admin socket path names collision #15048

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
2 participants
@trociny
Contributor

trociny commented May 11, 2017

If global admin_socket parameter is set, for PoolReplayer admin
sockets generate and use unique paths in $run_dir. Provide the socket
paths in output of PoolReplayer's "rbd mirror status" admin socket
command.

A possible use case:

  1. run "rbd mirror status $pool_replayer" command using global admin
    socket (known from configuration) and obtain socket paths for the
    PoolReplayer local and remote context sockets.
  2. Use these paths to run commands provides by the contexts.

Fixes: http://tracker.ceph.com/issues/19907
Signed-off-by: Mykola Golub mgolub@mirantis.com

@trociny

This comment has been minimized.

Contributor

trociny commented May 11, 2017

@dillaman What do you think about this approach?

@@ -464,6 +469,13 @@ void PoolReplayer::print_status(Formatter *f, stringstream *ss)
f->close_section();
}
f->dump_string("local_ctx_admin_socket",

This comment has been minimized.

@dillaman

dillaman May 12, 2017

Contributor

Nit: can we drop the "ctx_" portion of the key here and below (or perhaps swap it with "cluster_")? Otherwise, lgtm.

This comment has been minimized.

@trociny

trociny May 12, 2017

Contributor

@dillaman I am fine with dropping "ctx_" portion, as I don't like it very much too.Though don't you think it would be a little confusing for users, that is "local_admin_socket" vs "remote_admin_socket" would suggest the socket is located on local vs remote host?

This comment has been minimized.

@dillaman

dillaman May 12, 2017

Contributor

@trociny so swap "ctx" for "cluster" perhaps?

This comment has been minimized.

@trociny

trociny May 12, 2017

Contributor

@dillaman I like it! Thanks!

Mykola Golub
rbd-mirror: resolve admin socket path names collision
If global admin_socket parameter is set, for PoolReplayer admin
sockets generate and use unique paths in $run_dir. Provide the socket
paths in output of PoolReplayer's "rbd mirror status" admin socket
command.

A possible use case:

1) run "rbd mirror status $pool_replayer" command using global admin
   socket (known from configuration) and obtain socket paths for the
   PoolReplayer local and remote context sockets.
2) Use these paths to run commands provides by the contexts.

Fixes: http://tracker.ceph.com/issues/19907
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
@trociny

This comment has been minimized.

Contributor

trociny commented May 12, 2017

@dillaman updated

@dillaman

lgtm

@dillaman dillaman merged commit 6b86362 into ceph:master May 15, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@trociny trociny deleted the trociny:wip-19907 branch May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment