Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix error handling in Browser Uploads. #15054

Merged

Conversation

Projects
None yet
5 participants
@rzarzynski
Copy link
Contributor

commented May 11, 2017

The recent Coverity Scan for Ceph (published May 11, 2017 on ceph-devel) shows that the read_form_part_header method of RGWPostObj_ObjStore assigns to a variable but doesn't use it later. The anomaly is caused by lack of proper error handling. This commit rectifies it.

Signed-off-by: Radoslaw Zarzynski rzarzynski@mirantis.com

rgw: fix error handling in Browser Uploads.
The recent Coverity Scan for Ceph (published May 11, 2017 on
ceph-devel) shows that the read_form_part_header method of
RGWPostObj_ObjStore assigns to a variable but doesn't use it
later. The anomaly is caused by lack of proper error handling.
This commit rectifies it.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
@rzarzynski

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2017

The branch passes BulkTest of Tempest:

$ ./run_tempest.sh -V tempest.api.object_storage.test_account_bulk.BulkTest
WARNING: This script is deprecated and will be removed in the near future. Please migrate to tempest run or another method of launching a test runner
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-500} \
OS_TEST_LOCK_PATH=${OS_TEST_LOCK_PATH:-${TMPDIR:-'/tmp'}} \
${PYTHON:-python} -m subunit.run discover -t ${OS_TOP_LEVEL:-./} ${OS_TEST_PATH:-./tempest/test_discover} --list 
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-500} \
OS_TEST_LOCK_PATH=${OS_TEST_LOCK_PATH:-${TMPDIR:-'/tmp'}} \
${PYTHON:-python} -m subunit.run discover -t ${OS_TOP_LEVEL:-./} ${OS_TEST_PATH:-./tempest/test_discover}  --load-list /tmp/tmpEwTpr7
{0} tempest.api.object_storage.test_account_bulk.BulkTest.test_bulk_delete [0.277041s] ... ok
{0} tempest.api.object_storage.test_account_bulk.BulkTest.test_bulk_delete_by_POST [0.154525s] ... ok
{0} tempest.api.object_storage.test_account_bulk.BulkTest.test_extract_archive [0.089498s] ... ok

======
Totals
======
Ran: 3 tests in 3.0000 sec.
 - Passed: 3
 - Skipped: 0
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 0
Sum of execute time for each test: 0.5211 sec.

==============
Worker Balance
==============
 - Worker 0 (3 tests) => 0:00:00.522468

Also s3-tests haven't found a regression here (both for AWSv2 and AWSv4).

@yehudasa
Copy link
Member

left a comment

lgtm

@rzarzynski

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2017

jenkins retest this please

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2018

@cbodley cbodley merged commit c2da56c into ceph:master Feb 16, 2018

6 of 7 checks passed

make check (arm64) make check failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.