New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: osd: PrimaryLogPG: do not call on_shutdown() if (pg.deleting) #15065

Merged
merged 1 commit into from Aug 23, 2017

Conversation

Projects
None yet
6 participants
osd/PrimaryLogPG: do not call on_shutdown() if (pg.deleting)
when a callback is called, it could be facing a PG already shut down by
OSD. but if that callback wants to shut that PG down. it should check
the PG's status first.

Fixes: http://tracker.ceph.com/issues/19902
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit f3c44a0)

@liewegas liewegas added the bug fix label May 12, 2017

@liewegas liewegas added this to the jewel milestone May 12, 2017

@smithfarm smithfarm added the core label May 12, 2017

@smithfarm smithfarm changed the title from jewel: osd/PrimaryLogPG: do not call on_shutdown() if (pg.deleting) to jewel: osd: osd/PrimaryLogPG: do not call on_shutdown() if (pg.deleting) May 12, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jun 21, 2017

Contributor

Jenkins re-test this please

Contributor

smithfarm commented Jun 21, 2017

Jenkins re-test this please

@asheplyakov asheplyakov requested a review from badone Jun 30, 2017

@smithfarm smithfarm changed the title from jewel: osd: osd/PrimaryLogPG: do not call on_shutdown() if (pg.deleting) to jewel: osd: PrimaryLogPG: do not call on_shutdown() if (pg.deleting) Jul 12, 2017

@badone

badone approved these changes Aug 4, 2017

LGTM

@smithfarm smithfarm added the needs-qa label Aug 4, 2017

@smithfarm smithfarm requested a review from jdurgin Aug 23, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 23, 2017

Contributor

@badone @jdurgin This passed a rados suite with 1 failure ( a segfault - see http://tracker.ceph.com/issues/21063#note-2 ). Do you think it can be merged?

Edit:
@liewegas says that KStore is not supported, so I'm tentatively ruling the suite a "pass".

Contributor

smithfarm commented Aug 23, 2017

@badone @jdurgin This passed a rados suite with 1 failure ( a segfault - see http://tracker.ceph.com/issues/21063#note-2 ). Do you think it can be merged?

Edit:
@liewegas says that KStore is not supported, so I'm tentatively ruling the suite a "pass".

@smithfarm smithfarm merged commit 9502460 into ceph:jewel Aug 23, 2017

6 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment