New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Remove redundant includes - 1 #15086

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
3 participants
@joscollin
Member

joscollin commented May 15, 2017

Fixes: http://tracker.ceph.com/issues/19883 (Partially)
I hope this will help badone.

Signed-off-by: Jos Collin jcollin@redhat.com

@joscollin joscollin requested a review from badone May 15, 2017

@joscollin joscollin changed the title from common: Remove redundant includes to Do Not Review: common: Remove redundant includes May 15, 2017

@joscollin joscollin changed the title from Do Not Review: common: Remove redundant includes to common: Remove redundant includes May 15, 2017

@badone

Please wait for #15042 to merge as this PR will have conflicts with it. Setting DNM for now. once we fix the conflicts though this should be good and thanks for taking this on and don't let the conflicts discourage you :)

@badone badone changed the title from common: Remove redundant includes to [DNM] common: Remove redundant includes May 15, 2017

@joscollin

This comment has been minimized.

Member

joscollin commented May 16, 2017

@badone No Problem. I was expecting a conflict, as I didn't check which files you have modified in your unmerged PR.

In general, These header files are added when the developers add a new feature. But when they remove those features (or templates) in another PR, they don't bother to remove the header files. There are some files, in which all headers are unnecessary :-)

Please let me know when the merge of #15042 is done.

@badone badone changed the title from [DNM] common: Remove redundant includes to common: Remove redundant includes May 17, 2017

common: Remove redundant includes
Fixes: http://tracker.ceph.com/issues/19883 (Partially)

Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin

This comment has been minimized.

Member

joscollin commented May 17, 2017

@badone The #15042 is merged and the conflicts are resolved for this PR. Thanks for the review.

The #15042 is merged and the conflicts are resolved for this PR. Thanks for the review.

@badone

badone approved these changes May 17, 2017

LGTM

@liewegas liewegas merged commit a28c3ad into ceph:master May 18, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@joscollin joscollin changed the title from common: Remove redundant includes to common: Remove redundant includes - 1 May 19, 2017

@joscollin joscollin deleted the joscollin:wip-cleanup-redundant-headers-1 branch May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment