New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore/BlockDevice: support pmem device as bluestore backend #15102

Merged
merged 1 commit into from Jun 8, 2017

Conversation

Projects
None yet
3 participants
@majianpeng
Member

majianpeng commented May 16, 2017

It only reopen #8761 and next will rebuild code based on current code.

if(WITH_PMEM)
find_package(pmem REQUIRED)
set(HAVE_PMEM ${PMEM_FOUND})
endif(WITH_PMEM)

This comment has been minimized.

@liewegas

liewegas Jun 6, 2017

Member

this is fine for now, but do you know what the distro status of libpmem* is? we may need to include it as a submodule.

@liewegas

liewegas Jun 6, 2017

Member

this is fine for now, but do you know what the distro status of libpmem* is? we may need to include it as a submodule.

bufferlist &bl,
IOContext *ioc,
bool buffered)
{

This comment has been minimized.

@liewegas

liewegas Jun 6, 2017

Member

this can probably just call write()?

@liewegas

liewegas Jun 6, 2017

Member

this can probably just call write()?

@liewegas

This is pretty simple and sane; let's clean up just a few things and then get it merged.

If we don't expect libpmem to appear in distros soon we should build it as a submodule.

@liewegas liewegas changed the title from [RFC]os/bluestore/BlockDevice:support pmem device as bluestore backend. to [RFC]os/bluestore/BlockDevice: support pmem device as bluestore backend Jun 6, 2017

@majianpeng

This comment has been minimized.

Show comment
Hide comment
@majianpeng

majianpeng Jun 7, 2017

Member

@liewegas update by your advice. The git repo of libpmem is https://github.com/pmem/nvml.git.

Member

majianpeng commented Jun 7, 2017

@liewegas update by your advice. The git repo of libpmem is https://github.com/pmem/nvml.git.

@liewegas liewegas changed the title from [RFC]os/bluestore/BlockDevice: support pmem device as bluestore backend to os/bluestore/BlockDevice: support pmem device as bluestore backend Jun 7, 2017

@liewegas liewegas added the needs-qa label Jun 7, 2017

os/bluestore/BlockDevice:support pmem device as bluestore backend.
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

@liewegas liewegas merged commit b0e9f3e into ceph:master Jun 8, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@majianpeng majianpeng deleted the majianpeng:blockdevice-pmem branch Jun 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment