New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: minor fixes #15103

Merged
merged 3 commits into from May 17, 2017

Conversation

Projects
None yet
2 participants
@drunkard
Contributor

drunkard commented May 16, 2017

No description provided.

doc: change reference to internal link
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
@@ -604,9 +604,9 @@ Changing the Metadata Master Zone
To promote a zone (for example, zone ``us-2`` in zonegroup ``us``) to metadata
master, run the following commands on that zone::
$ radosgw-admin zone modify --rgw-zone=us-2 --master

This comment has been minimized.

@tchaikov

tchaikov May 16, 2017

Contributor

why do we need to re-indent these commands?

This comment has been minimized.

@drunkard

drunkard May 16, 2017

Contributor

All commands except this one uses 4 spaces as indention.

This comment has been minimized.

@tchaikov

tchaikov May 16, 2017

Contributor

so, again this is all about consistency. i'd lean towards keeping as it is. and change it when we happen to touch this area.

@@ -617,7 +617,7 @@ Failover and Disaster Recovery
If the master zone should fail, failover to the secondary zone for
disaster recovery.
1. Make the secondary zone the master and default zone. For example:
#. Make the secondary zone the master and default zone. For example:

This comment has been minimized.

@tchaikov

tchaikov May 16, 2017

Contributor

why is this a mistake?

This comment has been minimized.

@drunkard

drunkard May 16, 2017

Contributor

We uses #. everywhere, and from git log we also fixed some [0-9]..

This comment has been minimized.

@tchaikov

tchaikov May 16, 2017

Contributor

i am not sure i am following you. so it's more about consistency. and how come this is related to git log?

This comment has been minimized.

@drunkard

drunkard May 16, 2017

Contributor

Yes, it's about document style consistency, either we fix it now, or fix when add/remove sections.

So let it be for now?

drunkard added some commits May 16, 2017

doc: typo fixes in doc/radosgw/multisite
Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>
doc: add hyperlink on ACL settings
The link listed at bottom but never used, I think it's missed by author.

Signed-off-by: Drunkard Zhang <gongfan193@gmail.com>

@tchaikov tchaikov merged commit fab6fc1 into ceph:master May 17, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment