New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: use pre-defined calls to replace raw flag operation #15107

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
3 participants
@guihecheng
Contributor

guihecheng commented May 16, 2017

Signed-off-by: Gui Hecheng guihecheng@cmss.chinamobile.com

@@ -506,7 +506,7 @@ namespace rgw {
int open(uint32_t gsh_flags) {
lock_guard guard(mtx);
if (! (flags & FLAG_OPEN)) {
if (! (is_open())) {

This comment has been minimized.

@joscollin

joscollin May 18, 2017

Member

Can you remove the unnecessary brackets ?

This comment has been minimized.

@mattbenjamin

This comment has been minimized.

@guihecheng

guihecheng May 19, 2017

Contributor

Oh, yes, thanks.

@mattbenjamin mattbenjamin self-assigned this May 18, 2017

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented May 18, 2017

@guihecheng agree with above nit, but agree these consolidations are fine

@joscollin joscollin changed the title from rgw_file: use pre-defined calls to replace raw flag operation to rgw: use pre-defined calls to replace raw flag operation May 18, 2017

Gui Hecheng
rgw_file: use pre-defined calls to replace raw flag operation
Signed-off-by: Gui Hecheng <guihecheng@cmss.chinamobile.com>
@guihecheng

This comment has been minimized.

Contributor

guihecheng commented May 19, 2017

@mattbenjamin @joscollin updated as suggested :)

@joscollin joscollin merged commit f24f4c8 into ceph:master May 19, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@guihecheng guihecheng deleted the guihecheng:rgw_file-cleanup branch May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment