Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
rgw_file: fix misuse of make_key_name before make_fhk #15108
@guihecheng does this fix an observed problem? I agree, this will lead to an incorrect fh_key value and should have some observed effect. ok, so no, it probably has no observed effect, but changing it alters the value of object keys on the domain; we don't currently make any use of the stored value (which would be out-of-sync after this change);
ok, so we could only merge this change if we -at least- remove asserts on decoded key (from serialized ux_key1), and maybe need to revisit that, as it is not versioned; I think after discussing w/@cbodley that 1) because the decoder -is- versioned, we can make the assert conditional, and 2) we should then add logic for safely updating both metadata attributes affected (that should happen in a safe context, before returning from lookup_fh(), probably);
@mattbenjamin yes, I agree that, old versioned 'unix-key1' attr should be updated.