New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mention certain conf vars should be in global #15119

Merged
merged 1 commit into from Jun 2, 2017

Conversation

Projects
None yet
5 participants
@alimaredia
Contributor

alimaredia commented May 16, 2017

This is to make it apply whenever the radsogw-admin
command is run without specifying the instance name

Resolves: rhbz#1391500

Signed-off-by: Ali Maredia amaredia@redhat.com

@ktdreyer

This comment has been minimized.

Member

ktdreyer commented May 16, 2017

Let's avoid referring to RHBZs upstream?

@tchaikov tchaikov added the rgw label May 17, 2017

@dang

dang approved these changes May 17, 2017

doc: mention certain conf vars should be in global
This is to make it apply whenever the radsogw-admin
command is run without specifying the instance name

Signed-off-by: Ali Maredia <amaredia@redhat.com>
@alimaredia

This comment has been minimized.

Contributor

alimaredia commented May 19, 2017

@cbodley @tchaikov any reason this can't be merged yet?

Configuration variables set under the ``[client.radosgw.{instance-name}]``
section will not apply to rgw or radosgw-admin commands without an instance-name
specified in the command. Thus variables meant to be applied to all RGW
instances or all radosgw-admin commands can be put into the ``[global]`` or the

This comment has been minimized.

@tchaikov

tchaikov May 19, 2017

Contributor

@alimaredia i think the knowledge of

a setting in [global] section applies to all other sections

is orthogonal to what we are trying to convey here. if that is missing in the doc, we surely need to add it, but not to repeat it.

This comment has been minimized.

@ktdreyer

ktdreyer May 19, 2017

Member

eh, I don't think it hurts to repeat it here. We can't assume that the user has poured over every single doc page in detail :)

This comment has been minimized.

@tchaikov

tchaikov May 19, 2017

Contributor

aha, this makes a lot of sense! i withdraw my critique.

This comment has been minimized.

@ktdreyer

ktdreyer May 19, 2017

Member

❤️

This comment has been minimized.

@alimaredia

alimaredia May 19, 2017

Contributor

@tchaikov my rationale behind adding that sentence is many more variables besides rgw override bucket index max shards and rgw bucket default quota max objects could be added to the [global] section to be applied for all instances of the radosgw-admin command. This section is there to make people reading the docs mindful of that and make them think twice before adding variables to the [client.radosgw.{instance-name}] section.

This comment has been minimized.

@tchaikov

tchaikov May 19, 2017

Contributor

@alimaredia i wonder if the settings in [client.radosgw] apply to [client.radosgw.foo] and [client.radosgw.bar] ? if that works, it would be easier to understand and more manageable.

This comment has been minimized.

@alimaredia

alimaredia May 24, 2017

Contributor

@tchaikov I very quickly played around with this in ceph-ansible and I found that the settings in [client.rgw.foo] overrode those in [client.rgw] and [client]. The testing I did was not very rigorous by any means, but I think it's best to emphasize the vars should be in [global] if the intention is to have them apply everywhere.

This comment has been minimized.

@tchaikov

tchaikov Jun 2, 2017

Contributor

@alimaredia if the settings specified in [client.radosgw] does not apply to rgw or radosgw-admin commands without an instance-name specified in the command, and the ones specified in [global] do, we certainly need to emphasize that they should go to [global]. if that's the case, i am good with this change. otherwise, i think it would be better to limit the scope of the settings in [client.radosgw].

anyway, i don't feel strong either way. so lgtm.

@alimaredia

This comment has been minimized.

Contributor

alimaredia commented Jun 1, 2017

@tchaikov bump?

Configuration variables set under the ``[client.radosgw.{instance-name}]``
section will not apply to rgw or radosgw-admin commands without an instance-name
specified in the command. Thus variables meant to be applied to all RGW
instances or all radosgw-admin commands can be put into the ``[global]`` or the

This comment has been minimized.

@tchaikov

tchaikov Jun 2, 2017

Contributor

@alimaredia if the settings specified in [client.radosgw] does not apply to rgw or radosgw-admin commands without an instance-name specified in the command, and the ones specified in [global] do, we certainly need to emphasize that they should go to [global]. if that's the case, i am good with this change. otherwise, i think it would be better to limit the scope of the settings in [client.radosgw].

anyway, i don't feel strong either way. so lgtm.

@cbodley cbodley merged commit bf72bd8 into master Jun 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the wip-rgw-config-docs branch Jun 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment