New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/pglog: remove loop through empty collection #15121

merged 1 commit into from May 18, 2017


None yet
4 participants

ivancich commented May 16, 2017

At this point in the constructor missing is empty and therefore looping through it serves no purpose.

osd/pglog: Remove loop through empty collection.
Signed-off-by: J. Eric Ivancich <>

@ivancich ivancich requested a review from jdurgin May 16, 2017


This comment has been minimized.


ivancich commented May 16, 2017

Spotted this during other work but wanted to get eyes on it independently rather than being a small part of (and easily overlooked in) another pr.


nice catch

@tchaikov tchaikov added the needs-qa label May 17, 2017

@liewegas liewegas merged commit 4b0aa08 into ceph:master May 18, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Unmodifed Submodules submodules for project are unmodified
default Build finished.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment