New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: fix CDir::merge() for mds_debug_auth_pins #15130

Merged
merged 1 commit into from May 24, 2017

Conversation

Projects
None yet
3 participants
@ukernel
Member

ukernel commented May 17, 2017

Fixes: http://tracker.ceph.com/issues/19946
Signed-off-by: "Yan, Zheng" zyan@redhat.com

mds: fix CDir::merge() for mds_debug_auth_pins
Fixes: http://tracker.ceph.com/issues/19946
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
@fullerdj

This comment has been minimized.

Contributor

fullerdj commented May 17, 2017

In finish_old_fragment, we assert that STATE_STICKY is set (it is normally set in CInode::add_dirfrag). Should we remove the assertion or set it in CDir::split?

@fullerdj

This comment has been minimized.

Contributor

fullerdj commented May 17, 2017

On the merge side, CDir::merge calls close_dirfrag, which is unhappy having the extra ref now added by prepare_new_fragment.

@ukernel

This comment has been minimized.

Member

ukernel commented May 18, 2017

CDir::finish_old_fragment does not assert STATE_STICKY. depends on if STATE_STICKY is set, it assert dirfrag's ref is 0 or 1.

@fullerdj

This comment has been minimized.

Contributor

fullerdj commented May 18, 2017

I see what you mean, thanks.

@fullerdj

This comment has been minimized.

Contributor

fullerdj commented May 23, 2017

@jcsp this looks good to me, can we merge it?

@jcsp

jcsp approved these changes May 24, 2017

@jcsp jcsp merged commit 0f0fdeb into ceph:master May 24, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@ukernel ukernel deleted the ukernel:wip-19946 branch Jun 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment