Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: limit client writable range increment #15131

Merged
merged 2 commits into from May 24, 2017

Conversation

Projects
None yet
3 participants
@ukernel
Copy link
Member

ukernel commented May 17, 2017

For very large file, setting the writable range to '2 * file_size'
makes file recovery to run a long time. To recover a 1T file, Filer
needs to probe 1T~2T range.

Fixes: http://tracker.ceph.com/issues/19955
Signed-off-by: "Yan, Zheng" zyan@redhat.com

@jcsp

jcsp approved these changes May 17, 2017

@jcsp

This comment has been minimized.

Copy link
Contributor

jcsp commented May 17, 2017

I agree with this approach

@ukernel

This comment has been minimized.

Copy link
Member Author

ukernel commented May 17, 2017

this RP isn't complete. client code also assumes that max_size is '2 * file_size'. need to tune the client code

@ukernel ukernel changed the title [RFC] mds: limit client writable range increment mds: limit client writable range increment May 19, 2017

@ukernel ukernel force-pushed the ukernel:wip-19955 branch from 0eb0319 to 5187e69 May 19, 2017

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented May 19, 2017

👍

ukernel added some commits May 17, 2017

mds: limit client writable range increment
For very large file, setting the writable range to '2 * file_size'
causes file recovery to run a long time. To recover a 1T file, Filer
needs to probe 2T~1T range.

Fixes: http://tracker.ceph.com/issues/19955
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
client: update the 'approaching max_size' code
The old 'approaching max_size' code expects MDS set max_size to
'2 x reported_size'. This is no longer true. The new code reports
file size when half of previous max_size increment has been used.

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>

@ukernel ukernel force-pushed the ukernel:wip-19955 branch from 5187e69 to 9316b04 May 22, 2017

@ukernel

This comment has been minimized.

Copy link
Member Author

ukernel commented May 22, 2017

fix some typo in code comment and commit message, no code logic changes

@jcsp jcsp merged commit 4f5d7aa into ceph:master May 24, 2017

@ukernel ukernel deleted the ukernel:wip-19955 branch Jun 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.