Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix broken link in erasure-code.rst #15143

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
3 participants
@minshenglin
Copy link
Contributor

minshenglin commented May 18, 2017

doc: fix broken link in erasure-code.rst
Fixes: http://tracker.ceph.com/issues/19972
Signed-off-by: MinSheng Lin <minsheng.l@inwinstack.com>
@Liuchang0812

This comment has been minimized.

Copy link
Contributor

Liuchang0812 commented May 18, 2017

maybe we should create a test case since we support sphinx link-check already.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented May 18, 2017

@Liuchang0812 that would need network access. i am not 100% sure it's always available in the test environment. is it possible to disable it by default assuming we have that test already?

@tchaikov tchaikov merged commit 6f7b339 into ceph:master May 18, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@Liuchang0812

This comment has been minimized.

Copy link
Contributor

Liuchang0812 commented May 18, 2017

@tchaikov dirty but works solution: we create a test script that it check the network at first, then execute link-check if network is ok, else skip this test.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented May 18, 2017

i'd prefer adding an option which is OFF by default in CMake script, and enable it in our jenkins "make check" make run, and add the "link-check" test only if it's ON.

@Liuchang0812

This comment has been minimized.

Copy link
Contributor

Liuchang0812 commented May 18, 2017

it's a better solution. i create a issue to track this problem http://tracker.ceph.com/issues/19973

@minshenglin minshenglin deleted the minshenglin:fix_broken_link branch May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.