New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move bash_completion.d/ceph to ceph-common #15148

Merged
merged 2 commits into from May 19, 2017

Conversation

Projects
None yet
4 participants
@zealoussnow
Contributor

zealoussnow commented May 18, 2017

When only ceph-common is installed, can also use ceph completion

Signed-off-by: Leo Zhang nguzcf@gmail.com

build: move bash_completion.d/ceph to ceph-common
When only ceph-common is installed, can also use ceph completion

Signed-off-by: Leo Zhang <nguzcf@gmail.com>
@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov May 18, 2017

Contributor

this makes sense to me as ceph-common offers ceph cli, it'd be handy to include its bash-completion in that package as well. @zealoussnow do you mind do the same to debian/*. specifically, to move etc/bash_completion.d/ceph from debian/ceph-base.install to debian/ceph-common.install?

Contributor

tchaikov commented May 18, 2017

this makes sense to me as ceph-common offers ceph cli, it'd be handy to include its bash-completion in that package as well. @zealoussnow do you mind do the same to debian/*. specifically, to move etc/bash_completion.d/ceph from debian/ceph-base.install to debian/ceph-common.install?

@tchaikov tchaikov added the build/ops label May 18, 2017

@tchaikov tchaikov requested review from ktdreyer and smithfarm May 18, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm May 18, 2017

Contributor

This makes sense to me, too. Please add the debian bit as per @tchaikov.

Contributor

smithfarm commented May 18, 2017

This makes sense to me, too. Please add the debian bit as per @tchaikov.

build: move bash_completion.d/ceph from debian/ceph-base.install to d…
…ebian/ceph-common.install

when only ceph-common is installed, can also use ceph completion

Signed-off-by: Leo Zhang <nguzcf@gmail.com>
@zealoussnow

This comment has been minimized.

Show comment
Hide comment
@zealoussnow

zealoussnow May 18, 2017

Contributor

@tchaikov @smithfarm thank for your advice, I finished it.

Contributor

zealoussnow commented May 18, 2017

@tchaikov @smithfarm thank for your advice, I finished it.

@ktdreyer

Great catch @zealoussnow , thank you.

@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov May 19, 2017

Contributor

pushed to ceph-ci with name of wip-15148-kefu

Contributor

tchaikov commented May 19, 2017

pushed to ceph-ci with name of wip-15148-kefu

@tchaikov tchaikov self-assigned this May 19, 2017

@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov
Contributor

tchaikov commented May 19, 2017

@tchaikov tchaikov merged commit f6b388a into ceph:master May 19, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@zealoussnow zealoussnow deleted the zealoussnow:wip-spec branch May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment