New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw_file: remove extra rele() on fs in rgw_umount() #15152

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
2 participants
@guihecheng
Contributor

guihecheng commented May 18, 2017

We got exactly a refcnt=0 after rele in close,
no need to rele twice.

Signed-off-by: Gui Hecheng guihecheng@cmss.chinamobile.com

Gui Hecheng
rgw_file: fix extra rele on fs in close
We got exactly a refcnt=0 after rele in close,
no need to rele twice.

Signed-off-by: Gui Hecheng <guihecheng@cmss.chinamobile.com>
@joscollin

joscollin approved these changes May 18, 2017 edited

Yes, close() is calling rele() internally. So no need to call again. LGTM.

@joscollin joscollin changed the title from rgw_file: fix extra rele on fs in close to rgw_file: remove extra rele() on fs in rgw_umount() May 18, 2017

@joscollin joscollin merged commit 53a9ccf into ceph:master May 18, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@guihecheng guihecheng deleted the guihecheng:rgw_file-extra-rele branch May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment