New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph.in: assert(state==connected) before help_for_target() #15156

Merged
merged 1 commit into from May 25, 2017

Conversation

Projects
None yet
5 participants
@tchaikov
Contributor

tchaikov commented May 18, 2017

we always call "cluster_handle.connect()", and error out if connect()
fails.

Signed-off-by: Kefu Chai kchai@redhat.com

ceph.in: assert(state==connected) before help_for_target()
we always call "cluster_handle.connect()", and error out if connect()
fails.

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov added the cleanup label May 18, 2017

if (cluster_handle.state == "connected"):
help_for_target(target=('mon', ''), partial=partial)
assert(cluster_handle.state == "connected")
help_for_target(target=('mon', ''), partial=partial)
return 0

This comment has been minimized.

@joscollin

joscollin May 18, 2017

Member

The function always returns 0, no matter the state is connected or not. Will that be the same when assert(false) ?

This comment has been minimized.

@tchaikov

tchaikov May 18, 2017

Contributor

it will be the same.

This comment has been minimized.

@joscollin

joscollin May 18, 2017

Member

Alright.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 19, 2017

retest this please.

@tchaikov tchaikov requested review from gregsfortytwo and jdurgin May 19, 2017

@gregsfortytwo gregsfortytwo removed their request for review May 19, 2017

@yuriw yuriw merged commit 0f7e269 into ceph:master May 25, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-ceph.in-assert-connected branch May 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment