New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix boost components for WITH_SYSTEM_BOOST #15160

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
2 participants
@bassam
Member

bassam commented May 18, 2017

After #14850 when using WITH_SYSTEM_BOOST=ON the build fails since "container"
is a header only package and is not supported by FindBoost.cmake.

@@ -532,7 +534,7 @@ else()
set(BOOST_SOURCE_DIR "${PROJECT_SOURCE_DIR}/src/boost")
set(BOOST_PREFIX "${PROJECT_BINARY_DIR}/boost")
set(BOOST_BUILD "${PROJECT_BINARY_DIR}/boost-build")
string(REPLACE ";" "," BOOST_WITH_LIBS "${BOOST_COMPONENTS}")
string(REPLACE ";" "," BOOST_WITH_LIBS "${BOOST_COMPONENTS} ${BOOST_HEADER_COMPONENTS}")

This comment has been minimized.

@tchaikov

tchaikov May 18, 2017

Contributor

i think we need to list(APPEND BOOST_COMPONENTS ${BOOST_HEADER_COMPONENTS}") before doing the REPLACE.

This comment has been minimized.

@bassam

bassam May 18, 2017

Member

ok. I like that better. fixed in 23b0732

cmake: fix boost components for WITH_SYSTEM_BOOST
when using WITH_SYSTEM_BOOST dont set header-only packages
for BOOST_COMPONENTS. On some distros these packages dont
exist.

Signed-off-by: Bassam Tabbara <bassam.tabbara@quantum.com>

@tchaikov tchaikov added the build/ops label May 19, 2017

@tchaikov tchaikov merged commit 08c0b2a into ceph:master May 19, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment