New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Remove redundant includes - 2 #15169

Merged
merged 1 commit into from May 24, 2017

Conversation

Projects
None yet
3 participants
@joscollin
Member

joscollin commented May 19, 2017

Fixes: http://tracker.ceph.com/issues/19883 (Partially)

Signed-off-by: Jos Collin jcollin@redhat.com

@liewegas

This comment has been minimized.

Member

liewegas commented May 22, 2017

/build/ceph-12.0.2-1394-g793612f/src/common/url_escape.cc: In function 'std::string url_unescape(const string&)':
/build/ceph-12.0.2-1394-g793612f/src/common/url_escape.cc:39:12: error: 'runtime_error' is not a member of 'std'
      throw std::runtime_error(ss.str());
            ^
/build/ceph-12.0.2-1394-g793612f/src/common/url_escape.cc:52:12: error: 'runtime_error' is not a member of 'std'
      throw std::runtime_error(ss.str());
            ^

from https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=trusty,DIST=trusty,MACHINE_SIZE=huge/3432//consoleFull

common: Remove redundant includes
Fixes: http://tracker.ceph.com/issues/19883 (Partially)

Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin

This comment has been minimized.

Member

joscollin commented May 22, 2017

@liewegas Fixed, Please check now. Thanks.

@joscollin

This comment has been minimized.

Member

joscollin commented May 23, 2017

Retest this please

@badone

badone approved these changes May 23, 2017

LGTM

@liewegas liewegas merged commit f58ea04 into ceph:master May 24, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@joscollin joscollin deleted the joscollin:wip-cleanup-redundant-headers-2 branch Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment