New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/objectstore: Check apply_transaction return values #15171

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
2 participants
@ztczll
Contributor

ztczll commented May 19, 2017

Signed-off-by: zhanglei 243290414@qq.com

Check apply_transaction return values
Signed-off-by: zhanglei <243290414@qq.com>
@joscollin

The first argument of ASSERT_EQ is the expected value and the second argument is the actual value. But the opposite style is used in other instances of ASSERT_EQ too, in this file. So I suggest to follow that.

LGTM.

@joscollin joscollin changed the title from Check apply_transaction return values to test/objectstore: Check apply_transaction return values May 19, 2017

@joscollin joscollin merged commit fccae0f into ceph:master May 19, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@joscollin joscollin added the cleanup label May 19, 2017

varadakari added a commit to Flipkart/ceph that referenced this pull request Aug 15, 2017

osd/ReplicatedPG: do not proxy read *and* process op locally
If we proxy the read, we cannot return false, even if we fail to also
trigger a promotion.

Fixes: ceph#15171
Signed-off-by: Sage Weil <sage@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment