New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: fix a few bugs with the osd health reporting #15179

Merged
merged 4 commits into from May 23, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented May 19, 2017

No description provided.

liewegas added some commits May 19, 2017

mon/OSDMonitor: clean up whitespace a bit
Signed-off-by: Sage Weil <sage@redhat.com>
mon/OSDMonitor: adjust stray osd message a bit
'kept' seems wrong in this context.

Signed-off-by: Sage Weil <sage@redhat.com>
mon/OSDMonitor: separate health warnings into distinct messages
Each warning is a distinct message; the caller formats it as it deems
appropriate.

Signed-off-by: Sage Weil <sage@redhat.com>
mon/OSDMonitor: handle sparse type names
It's possible a type id isn't defined/used by crush.  Use the max id
instead and skip types without names.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas requested a review from neha-ojha May 19, 2017

@neha-ojha

The summary messages will include a semi colon.
Example:
HEALTH_WARN 6 pgs degraded; 2 pgs recovering; 4 pgs recovery_wait; 24 pgs stale; recovery 70/63 objects degraded (111.111%); 1 root (10 osds) down
; 2 rows (10 osds) down
; 3 racks (10 osds) down
; 5 hosts (10 osds) down
; 10 osds down

@liewegas liewegas merged commit e283924 into ceph:master May 23, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the liewegas:wip-fix-osd-health branch May 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment