New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: dev improve the s3tests doc to reflect current scripts #15180

Merged
merged 2 commits into from Jun 9, 2017

Conversation

Projects
None yet
2 participants
@theanalyst
Member

theanalyst commented May 19, 2017

minor improvements to the s3tests runner

  • make the workunit s3tests task to default to python2
  • add the current cmake build path to the workunit
  • drop the old info on the s3tests suite since the workunit does all of that
qa: run-s3tests: use python2 for s3tests & set PATH correctly
in case we're in a vstart deployment, update PATH so that rgw-admin is
found, also set path correctly if we're in a vstart env.

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

@theanalyst theanalyst requested review from liewegas, cbodley and smithfarm May 19, 2017

@@ -73,7 +69,7 @@ Options
Launch the osd/mds/mon/all the ceph binaries using valgrind with the specified tool and arguments.
.. option:: --{mon,osd,mds}_num
.. option:: --{mon,osd,mds,rgw}_num

This comment has been minimized.

@liewegas

liewegas May 19, 2017

Member

I'd prefer we got rid of these and consolidate support on OSD= MDS= MON= etc.

This comment has been minimized.

@theanalyst

theanalyst May 19, 2017

Member

Sounds good, also would work across all versions

@liewegas

This comment has been minimized.

Member

liewegas commented May 19, 2017

otherwise lgtm!

doc: dev: improve the s3tests with vstart document
update with the current qa workunits example and drop old info, also
update vstart doc dropping the -r and --num options to prefer env vars

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
@theanalyst

This comment has been minimized.

Member

theanalyst commented May 19, 2017

@liewegas updated

@theanalyst

This comment has been minimized.

Member

theanalyst commented Jun 9, 2017

@liewegas ping

@liewegas liewegas merged commit b6a5b94 into ceph:master Jun 9, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment