New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: add ceph::size() #15181

Merged
merged 1 commit into from May 20, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented May 19, 2017

backport from C++17

Signed-off-by: Kefu Chai kchai@redhat.com

common: add ceph::size()
backport from C++17

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov added the common label May 19, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 19, 2017

when i am reading https://github.com/ceph/ceph/pull/14997/files#diff-0f8df2ec9bc231870baa7dc572c34e2cR2308 , i feel that we could use std::size().

@tchaikov tchaikov requested review from adamemerson and cbodley May 20, 2017

@adamemerson

This is excellent, and you included an implementation of the array case which is good.

Lions Grow Their Manes.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 20, 2017

no users of this helper yet, so merge it!

@tchaikov tchaikov merged commit e3319da into ceph:master May 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-cxx1z-size branch May 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment