New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compressor: optimize header file dependency #15187

Merged
merged 1 commit into from May 23, 2017

Conversation

Projects
None yet
4 participants
@badone
Contributor

badone commented May 20, 2017

Follows on from ttps://github.com//pull/9287

Signed-off-by: Xiaowei Chen chen.xiaowei@h3c.com
Signed-off-by: Brad Hubbard bhubbard@redhat.com

#include "include/buffer.h"
#include "include/int_types.h"
#include "include/memory.h"

This comment has been minimized.

@tchaikov

tchaikov May 20, 2017

Contributor

i think we can ditch include/memory.h now, since all the goodies in TR in that header are included in C++11 standard.

@tchaikov

apart from the nit, lgtm.

compressor: optimize header file dependency
Signed-off-by: Xiaowei Chen <chen.xiaowei@h3c.com>
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

@badone badone added needs-qa and removed needs-review labels May 20, 2017

@yuriw yuriw merged commit aaaf48c into ceph:master May 23, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment