Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: Mark session connections down on shutdown #15192

Merged

Conversation

Projects
None yet
3 participants
@badone
Copy link
Contributor

badone commented May 22, 2017

Also return false early from OSD::ms_get_authorizer since it is
dangerous to proceed if we are shutting down.

Fixes: http://tracker.ceph.com/issues/19900

Signed-off-by: Brad Hubbard bhubbard@redhat.com

@badone badone requested a review from tchaikov May 22, 2017

@liewegas liewegas added the needs-qa label May 22, 2017

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented May 22, 2017

lgtm

@badone badone removed the request for review from tchaikov May 22, 2017

@badone

This comment has been minimized.

@@ -6655,6 +6655,11 @@ bool OSD::ms_get_authorizer(int dest_type, AuthAuthorizer **authorizer, bool for
{
dout(10) << "OSD::ms_get_authorizer type=" << ceph_entity_type_name(dest_type) << dendl;

if (is_stopping()) {
dout(10) << __func__ << " bailing, we are shutting down" << dendl;

This comment has been minimized.

Copy link
@tchaikov

tchaikov May 22, 2017

Contributor

@badone maybe we could make it a derr() or even an assert() ? with the fix of session->con->mark_down();, do you think we can run into this method if OSD is shutting down?

This comment has been minimized.

Copy link
@tchaikov

@badone badone force-pushed the badone:wip-tracker-19900-wait_auth_rotating-crash branch from f81ce78 to 5263bbc May 22, 2017

@badone

This comment has been minimized.

Copy link
Contributor Author

badone commented May 22, 2017

Will do QA once shaman is available again.

@badone

This comment has been minimized.

Copy link
Contributor Author

badone commented May 22, 2017

Jenkins, test this please

@badone badone force-pushed the badone:wip-tracker-19900-wait_auth_rotating-crash branch from 5263bbc to c172b9a May 23, 2017

@badone

This comment has been minimized.

Copy link
Contributor Author

badone commented May 24, 2017

Josh pointed me at OSD::shutdown and how early in the process we set_state(STATE_STOPPING). Based on that I don't think we want to assert there. I'm going to revert the assert back to the original code or derr() output @tchaikov OK?

@badone

This comment has been minimized.

Copy link
Contributor Author

badone commented May 24, 2017

Reverting to the original solution.

@badone badone force-pushed the badone:wip-tracker-19900-wait_auth_rotating-crash branch 2 times, most recently from cf9c165 to 6b880cb May 24, 2017

mgr: Mark session connections down on shutdown
Also assert in OSD::ms_get_authorizer since it is dangerous to proceed
if we are shutting down.

Fixes: http://tracker.ceph.com/issues/19900

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

@badone badone force-pushed the badone:wip-tracker-19900-wait_auth_rotating-crash branch from 6b880cb to eb5c02d May 24, 2017

@badone

This comment has been minimized.

@badone badone merged commit 0962497 into ceph:master May 25, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@badone badone deleted the badone:wip-tracker-19900-wait_auth_rotating-crash branch May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.