New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: rpm: move RDMA and python-prettytables build dependencies to distro-conditional section #15200

Merged
merged 2 commits into from May 25, 2017

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented May 22, 2017

SUSE ships this package under the name "rdma-core-devel". See
https://build.opensuse.org/package/view_file/openSUSE:Factory/rdma-core/rdma-core.spec?expand=1

Signed-off-by: Nathan Cutler ncutler@suse.com

build/ops: rpm: move RDMA build dependency to distro-conditional section
SUSE ships this package under the name "rdma-core-devel". See
https://build.opensuse.org/package/view_file/openSUSE:Factory/rdma-core/rdma-core.spec?expand=1

Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm added the build/ops label May 22, 2017

@smithfarm smithfarm requested review from tchaikov and ktdreyer May 22, 2017

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented May 22, 2017

This one is only needed for luminous.

@ktdreyer

This comment has been minimized.

Member

ktdreyer commented May 22, 2017

LGTM, want to edit the PR title to reflect the two changes?

@smithfarm smithfarm changed the title from build/ops: rpm: move RDMA build dependency to distro-conditional section to build/ops: rpm: move RDMA and python-prettytables build dependencies to distro-conditional section May 22, 2017

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented May 22, 2017

@ktdreyer thanks; done

@ktdreyer

This comment has been minimized.

Member

ktdreyer commented May 22, 2017

Thanks!

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented May 22, 2017

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented May 22, 2017

also testing in OBS

build/ops: rpm: move python-prettytable to distro-conditional section
The correct package name in SUSE is python-PrettyTable

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 25, 2017

@smithfarm please feel free to merge it once it builds in OBS also.

@smithfarm smithfarm merged commit e9a81ba into ceph:master May 25, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@smithfarm smithfarm deleted the smithfarm:wip-rdma-devel branch May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment